Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not enable image cropper if file is missing #1903

Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jul 17, 2020

What is this pull request for?

There is nothing to crop, if the image file is missing.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 5.0 milestone Jul 17, 2020
@tvdeyen tvdeyen requested a review from mamhoff July 17, 2020 10:59
@tvdeyen tvdeyen merged commit 3ede2b6 into AlchemyCMS:master Jul 17, 2020
@tvdeyen tvdeyen deleted the do-not-enable-cropper-for-missing-images branch July 17, 2020 11:27
bichinger-stm added a commit to bichinger/alchemy_cms that referenced this pull request Jul 17, 2020
…hemy_cms into active-storage-integration

* 'active-storage-integration' of github.com:bichinger/alchemy_cms:
  v5.0.0
  Do not convert JPEG images into JPG (AlchemyCMS#1904)
  Do not enable image cropper if file is missing (AlchemyCMS#1903)
  Always show original image as zoomed image (AlchemyCMS#1902)
  Rename Attachment#urlname into slug (AlchemyCMS#1848)
  Deprecate toolbar helper
  Bump version to 5.0.0.rc2
  Fix tag-list height
  Fix vertical position of site name in page tab
  Allow editing sites
  Fix missing help_text_text translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants