Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom mount points in Page::UrlPath #1921

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 7, 2020

What is this pull request for?

If an app mounts Alchemy at a non-root path we need to return that as prefix.

Closes #1918

Remove if no visual changes have been made.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tvdeyen Thomas von Deyen
If an app mounts Alchemy at a non-root path we need to return that as prefix.

Closes AlchemyCMS#1918
@tvdeyen tvdeyen added this to the 5.1 milestone Aug 7, 2020
@tvdeyen tvdeyen merged commit 9ece5d4 into AlchemyCMS:master Aug 7, 2020
@tvdeyen tvdeyen deleted the url_path-respects-mount-point branch August 7, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL-Path to / when mounted on /pages
2 participants