[a11y] Better image alt text support #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only using the alt_tag attribute of the essence picture this now supports passing the alt attribute via the html_options and adds a fallback to a humanized picture name. This ensures we always have an alt text for accessibility reasons.
tvdeyen
force-pushed
the
image-alt-text-fallback
branch
from
ad60e36 to
6d9cd1e
Compare
dividedharmony
approved these changes
Sep 22, 2020
tvdeyen
added a commit
that referenced
this pull request
Sep 29, 2020
Instead of only using the alt_tag attribute of the essence picture this now supports passing the alt attribute via the html_options and adds a fallback to a humanized picture name. This ensures we always have an alt text for accessibility reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Instead of only using the alt_tag attribute of the essence picture this now supports passing the alt attribute via the html_options and adds a fallback to a humanized picture name.
This ensures we alwaus have an alt text for accessibility reasons.
Checklist