Allow pound sign in legacy url #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinboening
commented
Dec 12, 2020
robinboening
force-pushed
the
allow_pound_sign_in_legacy_url
branch
from
377d598 to
7cebea8
Compare
tvdeyen
approved these changes
Dec 12, 2020
|
Hey 👋 I might become more active in 2021. |
|
@tvdeyen it seems travis is still a required check. I thought I've seen github actions for CI activated already, no? |
@robinboening I just merged to PR that activated GH actions again since Travis has changed their OpenSource plans. A rebase with latest |
We would love to have you back! |
robinboening
force-pushed
the
allow_pound_sign_in_legacy_url
branch
from
7cebea8 to
295294c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Currently its not possible to add a
LegacyPageUrlwith an anchor (e.gfoo/bar.php#baz).This change allows to add such HTML anchors (hash/pound signs) when adding/updating
LegacyPageUrlobjects.I believe this is a tiny but legit addition since
#signs are valid URI characters and it is a valid use case for theLegacyPageUrlfeature.Checklist