Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate elements fallbacks #1982

Merged
merged 2 commits into from
Dec 22, 2020

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 18, 2020

What is this pull request for?

  1. Deprecate fallback option of elements finder
    Providing fallback to render_elements or the ElementsFinder class will be removed from Alchemy 6.0
  2. Deprecate passing a String to render_elements from_page
    Passing a String to render_elements from_page option will not be supported anymore in Alchemy 6. Please load the page beforehand and pass it as object instead.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have removed tests that cover this behavior

@tvdeyen tvdeyen requested a review from mamhoff December 18, 2020 10:20
@tvdeyen tvdeyen added this to the 5.2 milestone Dec 18, 2020
@tvdeyen tvdeyen mentioned this pull request Dec 18, 2020
2 tasks
@tvdeyen tvdeyen force-pushed the deprecate-elements-fallbacks branch 2 times, most recently from 56061e7 to cdb97a5 Compare December 22, 2020 08:34
Providing fallback to render_elements or the ElementsFinder class will be removed from Alchemy 6.0
Passing a String to `render_elements` `from_page` option will
not be supported anymore in Alchemy 6. Please load the page
beforehand and pass it as object instead.
@tvdeyen tvdeyen force-pushed the deprecate-elements-fallbacks branch from cdb97a5 to 68da3c3 Compare December 22, 2020 08:44
@tvdeyen tvdeyen merged commit aa02942 into AlchemyCMS:main Dec 22, 2020
@tvdeyen tvdeyen deleted the deprecate-elements-fallbacks branch December 22, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant