Respect Language public status for page public status #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
page-public-if-language-public
branch
from
95cab72 to
caef536
Compare
tvdeyen
force-pushed
the
page-public-if-language-public
branch
from
caef536 to
1c8fc80
Compare
tvdeyen
commented
Feb 5, 2021
This is a very destrutive behavior and should not be done. Instead we should take the languages public status into account for the page publication status.
A page is only considered public if the language is also public. This is always the case for the default language, because there cannot be at least one public default language (assurred in the language validations).
tvdeyen
force-pushed
the
page-public-if-language-public
branch
from
1c8fc80 to
86e7223
Compare
In order to tell people that they should publish the language before publishing the page we disable the publish button with a nice little notice.
tvdeyen
force-pushed
the
page-public-if-language-public
branch
from
86e7223 to
96152f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
A page is only considered public if the language is also public. This is always the case for the default language, because there cannot be at least one public default language (assurred in the language validations).
Also do not unpublish all pages if language gets unpublished. This was a very destrutive behavior and should not be done.
Instead we should take the languages public status into account for the page publication status.
Checklist