Do not include unpublished pages in breadcrumb #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not make sense to include an unpublished page in a breadcrumb since the user is not able to navigate to it anyway.
This ability has only be used for the breadcrumb. Since the breadcrumb does not include any non-published pages anymore, we do not need this ability anymore.
tvdeyen
force-pushed
the
breadcrumb-no-unpublished-pages
branch
from
b0dd435 to
b6e0af9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
It does not make sense to include an unpublished page in a breadcrumb since the user is not able to navigate to it anyway.
Checklist