Add namespace for Tree related routes #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeTree is being used for rendering the Menu in tree structure. This Tree could be made generic so that it could be used at other places too. All that will be required is the fields similar to what we are using for Node, and the API endpoints. The API endpoints needs to be similar to what we have for Node. To differentiate and use the existing NodeTree.js, a namespace could be added so that it could be extended and new routes could be added it someone needs to make a similar Tree structure anywhere else too. This commit adds a namespace for existing Alchemy.routes for node type objects. The type is added as "node" at NodeTree.js, node_folder.hbs and _node.html.erb since these are the places from where the type data could be sent out and the current NodeTree works as expected. Similary, in future if it is required to use the currently implemented NodeTree, all that will be required is to extend and add the routes to the API with namespace, update the model similar to the Node model attribbutes and use Alchemy.NodeTree().
tvdeyen
reviewed
Feb 23, 2021
In the previous commits, NodeTree was supported with type feature such that it could be used generically. This caused an issue where existing Menu was not able to toggle. This commit updates node_folder to include data-record-id rather than data-node-id to fix the issue and align with the recent changes.
tvdeyen
requested changes
Feb 26, 2021
There was a problem hiding this comment.
After moving a node I am getting 404 errors from target_parent_id missing.
I think in this line we need to change node_id into record_id
https://github.com/AlchemyCMS/alchemy_cms/pull/2037/files?diff=unified&w=1#diff-bcd606e5cbbdeba1415b27e585e6fde84ad19c9bf1be5edbc662c8616e9759deL70
tvdeyen
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
NodeTree is being used for rendering the Menu in tree
structure. This Tree could be made generic so that it could be
used at other places too. All that will be required is the fields
similar to what we are using for Node, and the API endpoints.
The API endpoints needs to be similar to what we have for Node.
To differentiate and use the existing NodeTree.js, a namespace could
be added so that it could be extended and new routes could be added
it someone needs to make a similar Tree structure anywhere else too.
This PR adds a namespace for existing Alchemy.routes for node type
objects.
Similarly, in future if it is required to use the currently implemented
NodeTree, all that will be required is to extend and add the routes
to the API with namespace, update the model similar to the Node model
attributes and use Alchemy.NodeTree().
Notable changes
The type is added as "node" at NodeTree.js, node_folder.hbs and
_node.html.erb since these are the places from where the type data
could be sent out and the current NodeTree works as expected.
Checklist