Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instantiating a content on an unpersisted valid element #2056

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Mar 26, 2021

What is this pull request for?

Allows instantiating a content on an unpersisted element.

Checklist

@mamhoff mamhoff force-pushed the element-without-ids branch from 9188b5c to eb551e4 Compare March 26, 2021 13:36
mamhoff added 2 commits March 26, 2021 14:38
When copying an Essence, it needs to know its content - otherwise it
can't figure out what options it has.
Rails don't need a content, and neiter do we.
@mamhoff mamhoff force-pushed the element-without-ids branch from eb551e4 to abcaf18 Compare March 26, 2021 13:39
@mamhoff mamhoff changed the title Element without ids Allow instantiating a content on an unpersisted valid element Mar 26, 2021
@tvdeyen tvdeyen merged commit 365ea46 into AlchemyCMS:main Mar 26, 2021
@tvdeyen tvdeyen added this to the 6.0 milestone Mar 26, 2021
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants