Alchemy essence headline #2060
Merged
Alchemy essence headline #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
alchemy-essence-headline
branch
from
d29208c to
ef24726
Compare
tvdeyen
reviewed
Apr 8, 2021
mamhoff
force-pushed
the
alchemy-essence-headline
branch
from
ef24726 to
f2a83f6
Compare
tvdeyen
reviewed
Apr 9, 2021
This adds an Alchemy::EssenceHeadline. It has the following features:
When used as a preview text, it will show the level of the headline so
that content editors can see what levels they are using. There are is
also an optional `level` element.
Headlines can be configured through their content settings. One can
restrict the sizes and levels available to an element, by specifying them
like follows:
```yml
- name: MyComponent
contents:
- name: my_headline
type: EssenceHeadline
settings:
levels: [3, 4]
sizes: [3]
```
If, as in the previous example, `sizes` only has one option, the select
input in the element editor will not be displayed.
If `sizes` is unconfigured, the default will be an empty array, and the
essence will have no size class.
If we do not pass the content when building an essence, `after_initialize` hooks do not have access to the content definitions.
mamhoff
force-pushed
the
alchemy-essence-headline
branch
from
f2a83f6 to
defd7df
Compare
tvdeyen
reviewed
Apr 9, 2021
mamhoff
force-pushed
the
alchemy-essence-headline
branch
from
defd7df to
7672849
Compare
This is good to test this essence locally.
mamhoff
force-pushed
the
alchemy-essence-headline
branch
from
7672849 to
25528c7
Compare
tvdeyen
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This introduces an
Alchemy::EssenceHeadline. It has the following features:When used as a preview text, it will show the level of the headline so
that content editors can see what levels they are using. There are is
also an optional
levelelement.Headlines can be configured through their content settings. One can
restrict the sizes and levels available to an element, by specifying them
like follows:
If, as in the previous example,
sizesonly has one option, the selectinput in the element editor will not be displayed.
If
sizesis unconfigured, the default will be an empty array, and theessence will have no size class.
Checklist