Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete nested elements quickly #2065

Merged
merged 1 commit into from
Apr 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions app/models/alchemy/element.rb
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ class Element < BaseRecord

has_many :contents, dependent: :destroy, inverse_of: :element

before_destroy :delete_all_nested_elements

has_many :all_nested_elements,
-> { order(:position) },
class_name: "Alchemy::Element",
Expand Down Expand Up @@ -347,5 +349,18 @@ def touch_touchable_pages

touchable_pages.each(&:touch)
end

def delete_all_nested_elements
deeply_nested_elements = descendent_elements(self).flatten
DeleteElements.new(deeply_nested_elements).call
nested_elements.reset
all_nested_elements.reset
end

def descendent_elements(element)
element.all_nested_elements + element.all_nested_elements.map do |nested_element|
descendent_elements(nested_element)
end
end
end
end
14 changes: 14 additions & 0 deletions spec/models/alchemy/element_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -968,4 +968,18 @@ module Alchemy
end
end
end

describe "destroy callbacks" do
let(:element) { create(:alchemy_element) }
let!(:nested_element_1) { create(:alchemy_element, parent_element: element) }
let!(:nested_element_2) { create(:alchemy_element, parent_element: nested_element_1) }
let!(:nested_element_3) { create(:alchemy_element, parent_element: nested_element_2) }

it "destroys all the nested elements quickly" do
expect(Alchemy::DeleteElements).to receive(:new).with(
[nested_element_1, nested_element_2, nested_element_3]
).and_call_original
element.reload.destroy!
end
end
end