Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Re)-init Tinymce for elements with ingredients #2163

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 6, 2021

What is this pull request for?

If an element has ingredients we need to take those into
account as well if we create, delete or fold an element with
ingredients.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

If an element has ingredients we need to take those into
account as well if we create, delete or fold an element with
ingredients.
@tvdeyen tvdeyen added this to the 6.0 milestone Aug 6, 2021
@tvdeyen tvdeyen requested a review from robinboening August 6, 2021 08:02
Copy link
Contributor

@robinboening robinboening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

<% @element.richtext_contents_ids.each do |id| %>
tinymce.get('tinymce_<%= id %>').remove();
<% end %>
Alchemy.Tinymce.remove(<%= @richtext_ids.to_json %>);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@tvdeyen tvdeyen merged commit c841676 into AlchemyCMS:main Aug 6, 2021
@tvdeyen tvdeyen deleted the fix-tinymce-init-for-ingredients branch August 6, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants