Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure resource table ends before the filter/tag sidebar #2166

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

robinboening
Copy link
Contributor

@robinboening robinboening commented Aug 7, 2021

What is this pull request for?

A wide resource table in combination with the sidebar for filter/tags made the table slip under the sidebar. As a consequence it would hide the edit/delete buttons and even some attributes.

This commit enforces the width of the resource-table-wrapper can always only be as wide as it doesn't slip under the library_sidebar.

Screenshots

Before

Screenshot 2021-08-07 at 21 41 27

After

Screenshot 2021-08-07 at 21 40 37

A wide resource table in combination with the sidebar for filter/tags made the table slip under the sidebar. As a consequence it would hide the edit/delete buttons and even some attributes.

This commit enforces the width of the resource-table-wrapper can always only be as wide as it doesn't slip under the library_sidebar.
@robinboening robinboening requested a review from tvdeyen August 7, 2021 19:40
@robinboening robinboening changed the title Ensure resource table ends before filter/tag bar Ensure resource table ends before the filter/tag sidebar Aug 7, 2021
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 Thank you!

@tvdeyen tvdeyen merged commit 13f8c22 into AlchemyCMS:main Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants