Fix ingredient form field DOM ids #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the ID was not unique producing duplicated DOM ids for multiple instances of the same element type on the same page. Since we want to be able to access the input via JS we need to have a unique DOM ID.
tvdeyen
force-pushed
the
uniq-ingredient-form_field_id
branch
from
8018dff to
e096660
Compare
These editors need a unique dom id to work correctly with their js events.
These ingredients do not have JS events and the id rails generates is not unique, so we remove them to avoid DOM exceptions/warnings.
Make the input field readonly and remove the hidden field. That way we can still see the link value.
tvdeyen
force-pushed
the
uniq-ingredient-form_field_id
branch
from
e096660 to
0a4b407
Compare
robinboening
approved these changes
Aug 10, 2021
tvdeyen
added a commit
to tvdeyen/alchemy-solidus
that referenced
this pull request
Aug 11, 2021
We need to have unique DOM ids for ingredient editors Follows AlchemyCMS/alchemy_cms#2167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Before the IDs where not unique; producing duplicated DOM ids for multiple instances of the same element type on the same page.
Since we want to be able to access the input via JS we need to have a unique DOM ID.
Also removes a lot of superfluous DOM ids that Rails generates to reduce DOM warnings.
Checklist