Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ingredients value if element asked for ingredient #2170

Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 10, 2021

What is this pull request for?

Adds deprecated support for returning an ingredients value if the element is asked for its ingredient. This helps to migrate existing sites to ingredients.

With the next version of Alchemy this behavior will change to return the ingredient record instead.

A helpful deprecation notice is logged.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 6.0 milestone Aug 10, 2021
@tvdeyen tvdeyen requested a review from a team August 10, 2021 17:25
Adds deprecated support for returning an ingredients value if the element
is asked for its ingredient. This helps to migrate existing sites to ingredients.

With the next version of Alchemy this behavior is changed to return the ingredient
record instead.

A helpful deprecation notice is logged.
@tvdeyen tvdeyen force-pushed the support-ingredients-element-helpers branch from bb8e37c to c9dc4ac Compare August 10, 2021 19:06
@tvdeyen tvdeyen merged commit 64194df into AlchemyCMS:main Aug 11, 2021
@tvdeyen tvdeyen deleted the support-ingredients-element-helpers branch August 11, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants