Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused route #2238

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Conversation

phantomwhale
Copy link
Contributor

@phantomwhale phantomwhale commented Feb 14, 2022

There is no Alchemy::ContentsController to handle any requests to this
route. It was likely added by accident as part of 871e77e

Given this route only produces errors, it makes most sense to remove it
here

What is this pull request for?

Closes #2237

Notable changes (remove if none)

Removes the unused /contents/:id route from the Alchemy engine routes list

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change (N/A ?)

There is no Alchemy::ContentsController to handle any requests to this
route. It was likely added by accident as part of AlchemyCMS@871e77e

Given this route only produces errors, it makes most sense to remove it
here
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tvdeyen tvdeyen merged commit 924d65f into AlchemyCMS:main Feb 14, 2022
@phantomwhale phantomwhale deleted the remove-unused-route branch April 14, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route /contents/:id does not have a controller
2 participants