Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lodash-es instead of lodash #2268

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Use lodash-es instead of lodash #2268

merged 1 commit into from
Mar 18, 2022

Conversation

afdev82
Copy link
Contributor

@afdev82 afdev82 commented Mar 18, 2022

What is this pull request for?

Change to use lodash-es package instead of lodash.

Closes #2264

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

tvdeyen
tvdeyen approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly. Tested manually. Thank you.

@tvdeyen tvdeyen merged commit 47736ed into AlchemyCMS:main Mar 18, 2022
@tvdeyen tvdeyen added this to the 6.0 milestone Mar 18, 2022
@afdev82 afdev82 deleted the fix_dependency branch March 18, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

Missing lodash dependency for admin js package
2 participants
@afdev82 @tvdeyen