Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't delete locals in render_element so they can be used by all elements in render_elements #2283

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Don't delete locals in render_element so they can be used by all elements in render_elements #2283

merged 1 commit into from
Apr 6, 2022

Conversation

dbwinger
Copy link
Contributor

@dbwinger dbwinger commented Apr 6, 2022

What is this pull request for?

Fix a bug which was preventing the locals option passed to Alchemy::ElementsHelper#render_elements from being passed to more than the first element, due to delete being called on the options hash.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@dbwinger dbwinger force-pushed the render-element-locals branch from 9b7f3ff to bc2c025 Compare April 6, 2022 18:57
tvdeyen
tvdeyen approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tvdeyen tvdeyen merged commit eb3ad03 into AlchemyCMS:main Apr 6, 2022
@dbwinger dbwinger deleted the render-element-locals branch April 7, 2022 15:25
@dbwinger dbwinger mentioned this pull request Apr 7, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbwinger @tvdeyen