Allow pasting into parent element with only one nested element type #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwinger
force-pushed
the
paste-single-element
branch
3 times, most recently
from
1ff59b9 to
8e12921
Compare
tvdeyen
reviewed
Apr 14, 2022
There was a problem hiding this comment.
This works well, unless you copy the element from the same page, because the button doesn't update the link on the "Add nested element button". A bit tricky, but you could update the link via Javascript on "copy element". This is kind of an edge case, though.
Good point. I just took a crack at that. |
dbwinger
force-pushed
the
paste-single-element
branch
from
d9f8331 to
9d40c82
Compare
dbwinger
force-pushed
the
paste-single-element
branch
from
0211346 to
95b3d39
Compare
tvdeyen
reviewed
Apr 19, 2022
tvdeyen
added a commit
that referenced
this pull request
Apr 26, 2022
Allow pasting into parent element with only one nested element type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Before this change, the new element dialog (including the option to paste) is not shown when adding a nested element when the parent element only has a one nestable element type.
This change shows the dialog in this case only if the clipboard contains an element with the name of the nestable element type. In this case, the element select is disabled (and shows the only option).
Checklist