Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gif resizing #2315

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Fix gif resizing #2315

merged 1 commit into from
Apr 26, 2022

Conversation

kulturbande
Copy link
Contributor

@kulturbande kulturbande commented Apr 25, 2022

What is this pull request for?

A new Dragonfly processor which is an extension of the Dragonfly thumb processor to handle also animated GIFs.

Notable changes (remove if none)

All thumbnail generations will run through this new processor.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think we can reduce the amount of code necessary a bit more.

With the default thumb - method the GIFs have artifacts  after the second frame. To prevent this an additional processor was added.
@kulturbande kulturbande force-pushed the feature/gif-resizing branch from 2a57c61 to 37dece4 Compare April 26, 2022 06:54
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tvdeyen tvdeyen changed the title Feature/gif resizing Fix gif resizing Apr 26, 2022
@tvdeyen tvdeyen merged commit d07f74e into AlchemyCMS:main Apr 26, 2022
tvdeyen added a commit that referenced this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants