Add support for Rails' recycable cache keys #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been a feature from Rails 5.2 and is enabled by default from Rails 6.0 and above.
mamhoff
approved these changes
May 5, 2022
tvdeyen
added a commit
that referenced
this pull request
May 6, 2022
Add support for Rails' recycable cache keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This has been a feature from Rails 5.2 and is enabled by default
from Rails 6.0 and above.
Notable changes
Page#cache_keynow simply returns"alchemy/page/<id>"(the Rails default).Since Rails 6.0 has turned on
Rails.application.config.active_record.cache_versioningby default and then usescache_key_with_version(that then callscache_version) we can safely make this change.In the unlikely case that someone had turned off
Rails.application.config.active_record.cache_versioningin a Rails 6 application this will "break" the cache, but I think we can take the risk.Checklist