Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Site managers to remove page locks #2360

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jul 22, 2022

One of my client has page locks that are years old, due to users that
are not in the organization any longer and that never properly locked
out. This change allows admin users to remove stale page locks.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

One of my client has page locks that are years old, due to users that
are not in the organization any longer and that never properly locked
out. This change allows admin users to remove stale page locks.
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!

FYI: Pages can still be edited, even if they are still locked, as long as the user is not online anymore.

return false if !@page.locker.try(:logged_in?)

@tvdeyen tvdeyen merged commit 5e21ec5 into AlchemyCMS:main Jul 25, 2022
tvdeyen added a commit that referenced this pull request Jul 25, 2022
…tale-page-locks

Allow Site managers to remove page locks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants