Fix page seeder #2389
Merged
Fix page seeder #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
fix-page-seeder
branch
from
c76153f to
8137117
Compare
|
As discussed IRL, page creation should probably live in some kind of factory object, as the internals of the page are becoming increasingly complex. |
|
This pull request has not seen any activiy in a long time. |
|
This pull request has not seen any activiy in a long time. |
|
We need that, so the demo can be deployed. Addressing the comment in another PR |
Merged
Ruby 3.1 does not allow Date in yml by default anymore.
If you pass a public_on date to the page seeder, Alchemy will create a public version (because of the public_on= attribute writer). The before_create filter kicks in too late, leading to public pages without a draft version. Tried to use different before filters in the page model, but nothing worked. So I fixed the problem where it happens in the page seeder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
If you pass a public_on date to the page seeder,
Alchemy will create a public version (because of the
public_on=attribute writer). The before_create filterkicks in too late, leading to public pages without a
draft version.
Tried to use different before filters in the page model,
but nothing worked. So I fixed the problem where it
happens in the page seeder.
Checklist