Remove all content/essence related code #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
remove-essences
branch
from
c7dd085 to
e59db6d
Compare
This is a HUGE commit, but it is atomic and this is good.
There must not be the same role defined twice per element.
We dont have contents anymore, we have ingredients. And they have a foreign key with ON DELETE CASCADE set.
tvdeyen
force-pushed
the
remove-essences
branch
from
e59db6d to
a34dcc7
Compare
tvdeyen
force-pushed
the
remove-essences
branch
from
a34dcc7 to
a9158ab
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Replaces content with ingredient where appropiate. Removes some old left overs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Removes everything from the code base around the deprecated and replaced
Alchemy::Essence*andAlchemy::Contentclasses, all related methods, specs and views.
Please refer to #2413 in order to update to ingredients before upgrading to 7.0
Notable changes (remove if none)
This is a HUGE commit, but it is atomic and this is good.
Checklist