Remove webpacker #2424
Merged
Remove webpacker #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
remove-webpacker
branch
from
985d5dc to
e40b463
Compare
Webpacker is not supported anymore by the Rails team and we have plenty of other options nowadays. The installer supports either jsbundling-rails or importmaps-rails and will auto detect which one to use. The dummy app uses jsbundling rails with esbuild as bundler for fast CI builds.
If someone uses the alchemy admin with sourcemaps we need a built package.
We do not have a bundler locally so we need to use the bundled package.
We want to be sure yarn founds the package
tvdeyen
force-pushed
the
remove-webpacker
branch
from
d09f9d6 to
9420293
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| log "Installed new npm package." | ||
| desc "Update npm package." | ||
| if File.exist? Rails.root.join("config/importmap.rb") | ||
| `bin/importmap pin @alchemy_cms/admin@~#{Alchemy.version}` |
Check warning
Code scanning / Brakeman
Possible command injection.
| if File.exist? Rails.root.join("config/importmap.rb") | ||
| `bin/importmap pin @alchemy_cms/admin@~#{Alchemy.version}` | ||
| elsif File.exist? Rails.root.join("package.json") | ||
| `yarn add @alchemy_cms/admin@~#{Alchemy.version}` |
Check warning
Code scanning / Brakeman
Possible command injection.
Supports removing webpacker and adding jsbundling-rails
tvdeyen
force-pushed
the
remove-webpacker
branch
from
cf2273d to
01f9a55
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
This is not a command injection because we now the content of `Alchemy.version`. It is a harmless string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Remove Webpacker and detect either importmaps or jsbundling-rails during install
Closes #2388
Checklist