Add PictureThumb.storage_class #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
added a commit
to AlchemyCMS/alchemy-dragonfly-s3
that referenced
this pull request
Feb 26, 2023
Can be removed once AlchemyCMS/alchemy_cms#2435 has been merged.
tvdeyen
force-pushed
the
use-picture-thumb-store
branch
2 times, most recently
from
65a0829 to
b673ec5
Compare
Instead of configuring a `PictureThumb.generator_class` that needs to implement the creation of the `Alchemy::PictureThumb` records and make sure do that in a multi-concurrency safe way, we keep the implementation in core and abstract the storage class instead.
tvdeyen
force-pushed
the
use-picture-thumb-store
branch
from
b673ec5 to
11faeef
Compare
tvdeyen
added a commit
to AlchemyCMS/alchemy-dragonfly-s3
that referenced
this pull request
Feb 27, 2023
Can be removed once AlchemyCMS/alchemy_cms#2435 has been merged.
mamhoff
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Instead of configuring a
PictureThumb.generator_classthat needsto implement the creation of the
Alchemy::PictureThumbrecordsand make sure do that in a multi-concurrency safe way, we keep
the implementation in core and abstract the storage class instead.
Checklist