Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non_stupid_digest_assets #2436

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Mar 7, 2023

We imported the file from a wrong version. We need the version that allows a RegExp whitelist.

@tvdeyen tvdeyen force-pushed the fix-non-stupid-assets branch from 5b26dd9 to d7d851a Compare March 7, 2023 14:00
@afdev82
Copy link
Contributor

afdev82 commented Mar 7, 2023

We imported the file from a wrong version. We need the version that allows a RegExp whitelist.

That's strange, I have copied the file from here: https://github.com/alexspeller/non-stupid-digest-assets/blob/master/lib/non-stupid-digest-assets.rb
If I open the gem used previously by AlchemyCMS, I see exactly the same file, so I don't get it...

@tvdeyen
Copy link
Member Author

tvdeyen commented Mar 7, 2023

@afdev82 it seems the released gem version does have the correct version https://github.com/alexspeller/non-stupid-digest-assets/blob/1.0.4/lib/non-stupid-digest-assets.rb

We imported the file from a wrong version. We need the
version that allows a RegExp whitelist.
@tvdeyen tvdeyen force-pushed the fix-non-stupid-assets branch from d7d851a to 5384d9a Compare March 7, 2023 14:48
@tvdeyen tvdeyen enabled auto-merge March 7, 2023 14:52
@tvdeyen tvdeyen merged commit 99b547f into AlchemyCMS:main Mar 7, 2023
@tvdeyen tvdeyen deleted the fix-non-stupid-assets branch March 7, 2023 14:54
@afdev82
Copy link
Contributor

afdev82 commented Mar 7, 2023

If I install the bundle, I get the latest version (1.0.9).
That part of code was changed, but I have found the problem anyway: I have changed (due to a rubocop complaint), the ===to ==. That's why it didn't work anymore, sorry for that.
In production I had the old compiled files, so I haven't realized that the ones without the digest were missing.

@tvdeyen
Copy link
Member Author

tvdeyen commented Mar 7, 2023

No worries. We have tests now, so its better than before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants