Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use view_component for ingredient views #2465

Merged
merged 19 commits into from
May 24, 2023
Merged

Use view_component for ingredient views #2465

merged 19 commits into from
May 24, 2023

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 3, 2023 •
edited
Loading

What is this pull request for?

Introduce View Components as View classes for Ingredients.

Notable changes (remove if none)

Stops rendering the _view partial for ingredients under app/views/alchemy/ingredients.

Deprecates render the ingredient view directly.

@tvdeyen tvdeyen requested a review from sascha-karnatz May 3, 2023 20:38
@tvdeyen tvdeyen changed the title View components Use View components May 4, 2023
@tvdeyen tvdeyen force-pushed the view-components branch from 8f1bb31 to 3cb34e2 Compare May 4, 2023 06:28
@tvdeyen tvdeyen force-pushed the view-components branch 3 times, most recently from 1fdb549 to d1eed03 Compare May 10, 2023 06:43
@tvdeyen tvdeyen changed the title Use View components Use View components for ingredient views May 10, 2023
@tvdeyen tvdeyen changed the title Use View components for ingredient views Use view_component for ingredient views May 10, 2023
tvdeyen added 15 commits May 15, 2023 21:55
@tvdeyen
Add view_component
dbc3e07
@tvdeyen
Convert Alchemy::PictureView into ViewComponent
9e58534
@tvdeyen
Move PictureView component into ingredients folder
13b2764
@tvdeyen
PictureView: Split component and picture url options
2371ff9 
Make it more obvious what options are for the component
view and which are we passing to the picture#url method.
@tvdeyen
Add Ingredients::AudioView component
d1f579f
@tvdeyen
Add Ingredients::BooleanView component
59a744c
@tvdeyen
Add Ingredients::DatetimeView component
5ed71e5
@tvdeyen
Add Ingredients::FileView component
cddce3f
@tvdeyen
Add Ingredients::HeadlineView component
26ff210
@tvdeyen
Add Ingredients::LinkView component
148f8ef
@tvdeyen
Add Ingredients::PageView component
92d9d66
@tvdeyen
Add Ingredients::RichtextView component
4daf058
@tvdeyen
Add Ingredients::TextView component
c4c1671
@tvdeyen
Add Ingredients::SelectView component
773e1a1
@tvdeyen
Add Ingredients::NodeView component
f2117bc
tvdeyen added 4 commits May 15, 2023 21:55
@tvdeyen
Add Ingredients::HtmlView component
be75dac
@tvdeyen
Add Ingredients::VideoView component
0f2e4dc
@tvdeyen
Add rubocop to dev gems
9934011 
Need that in order for editors with autoformatting work
correctly. We use standardrb to format, but that uses rubocop
to lint.
@tvdeyen
Render ingredients as view components
f36872d 
Instead of rendering the view partial of the ingredient
we render it view component instead.

Deprecates the ingredients view partials.
@tvdeyen tvdeyen force-pushed the view-components branch from 9ad38a7 to f36872d Compare May 16, 2023 18:35
@tvdeyen tvdeyen marked this pull request as ready for review May 23, 2023 19:20
@tvdeyen tvdeyen merged commit 4a04814 into AlchemyCMS:main May 24, 2023
@tvdeyen tvdeyen deleted the view-components branch May 24, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sascha-karnatz sascha-karnatz Awaiting requested review from sascha-karnatz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tvdeyen