Collapse all nested elements on fold #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
changed the title
sascha-karnatz
approved these changes
May 11, 2023
sascha-karnatz
approved these changes
May 11, 2023
On a page with lots of nested elements multiple levels deep the performance regresses very much especially with lots of TinyMCE instances. Also UX is getting messy very soon. In order to make the page faster and clean up the interface, we now collapse all nested elements and their nested elements if an element gets folded by the user. Next time the element expands it will present all nested elements collapsed to the user making a) the UX much faster and more cleaned up.
We need to render nested elements even if the element is folded, because we need the element present in the DOM for the feature "click element in the preview => load and expand element editor". Together with the previous commit where introduced collapsing of all nested elements if we fold an element, the performance is much better now. This reverts commit 0d7a7f9
tvdeyen
force-pushed
the
collapse-nested-elements-on-fold
branch
from
fbdad8a to
6e1850e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
On a page with lots of nested elements multiple levels deep
the performance regresses very much especially with lots of
TinyMCE instances. Also UX is getting messy very soon.
In order to make the page faster and clean up the interface,
we now collapse all nested elements and their nested elements
if an element gets folded by the user. Next time the element
expands it will present all nested elements collapsed to the
user making a) the UX much faster and more cleaned up.
This also reverts #2470
because we need to render nested elements even if the element is folded,
because we need the element present in the DOM for the feature
"click element in the preview => load and expand element editor".
Screenshots
Remove if no visual changes have been made.
Checklist