Use intersection observer to init Tinymce editors #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-karnatz
force-pushed
the
tinymce-intersection-observer
branch
7 times, most recently
from
8e6fce5 to
5f3cce3
Compare
sascha-karnatz
changed the title
Change Tinymce default configuration - name to not overwrite the Tinymce object.
Change the command position of the admin package link during the dummy app installation. Otherwise the alchemy:install - step will reinstall the package.
sascha-karnatz
force-pushed
the
tinymce-intersection-observer
branch
from
8b604d7 to
6db555a
Compare
Also add a method to set custom tinymce configuration, instead of exporting the whole configuration.
One jQuery usage is left because it is used in initializer and dialog. It has to be removed, when these parts are updated.
the IntersectionObserver will initialize each instance of the Tinymce only if it becomes visible. This can drastically reduce Javascript long tasks on pages with a lot of Tinymce instances.
sascha-karnatz
force-pushed
the
tinymce-intersection-observer
branch
from
e0bd795 to
16215f6
Compare
sascha-karnatz
changed the title
tvdeyen
reviewed
May 24, 2023
tvdeyen
changed the title
tvdeyen
changed the title
Instead of a CSS class the id of the element is used to target the Tinymce textarea. Also the configuration is now in the richtext editor template.
sascha-karnatz
force-pushed
the
tinymce-intersection-observer
branch
from
16215f6 to
2f3b882
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Checklist