Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused javascript #2506

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

sascha-karnatz
Copy link
Contributor

What is this pull request for?

Remove not used Javascript functions. This is a cherry pick of the pull request #2501 to make easier to test.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

it isn't used (not even imported). Also the tested functions are available in all major browsers.
they are not used anywhere. So it is save to remove them.
@sascha-karnatz sascha-karnatz requested a review from tvdeyen June 30, 2023 12:58
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ✂️

@tvdeyen tvdeyen added this to the 7.0 milestone Jun 30, 2023
@tvdeyen tvdeyen enabled auto-merge June 30, 2023 13:04
@tvdeyen tvdeyen merged commit b98af3e into AlchemyCMS:main Jun 30, 2023
@sascha-karnatz sascha-karnatz deleted the remove-unused-javascript branch July 3, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants