Copying pages: Only add "(Copy)" if necessary #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Jul 31, 2023
|
@mamhoff ping |
This should help with copying and pasting page trees. If one copies to a different parent page from the source page, then we don't need to add the "(Copy)" string to the new page. This is especially useful for copying larger structures between language trees.
mamhoff
force-pushed
the
do-not-add-copy-unless-necessary
branch
from
ca0f9ba to
bb6ac7b
Compare
This class copies a page, respecting the need for changing the name of the page if the new parent page already has a child with that name. It's an extraction of code from the Alchemy::Page model. There's nothing "new" here, except for the API.
This method is already in the model file.
This uses the new CopyPage class anywhere we need it in the Alchemy::Page model.
mamhoff
force-pushed
the
do-not-add-copy-unless-necessary
branch
from
bb6ac7b to
fd9c9c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This should help with copying and pasting page trees. If one copies to a different parent page from the source page, then we don't need to add the "(Copy)" string to the new page. This is especially useful for copying larger structures between language trees.
Notable changes (remove if none)
Much less
(Copy).Checklist