Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable unauthorized path #2522

Merged
merged 6 commits into from
Jul 31, 2023
Merged

Add configurable unauthorized path #2522

merged 6 commits into from
Jul 31, 2023

Conversation

gr8bit
Copy link
Contributor

@gr8bit gr8bit commented Jul 16, 2023

What is this pull request for?

When a user is logged in and requests a page she does not have access to in the admin panel, she becomes redirected to "/" which was hardcoded.

This PR adds an unauthorized_path configuration option to configure the path for that case. Simple & straightforward. :)

Checklist

  • I have followed Pull Request guidelines
  • [_] I have added a detailed description into each commit message Please Squash
  • I have added tests to cover this change

@tvdeyen
Copy link
Member

tvdeyen commented Jul 31, 2023

@gr8bit thanks.

Regarding the commit message requirement: Squashing doe not help here, because none of the commits contain a description, just a commit title. Could you use the PR description as commit message for the first commit? I can squash them then.

@tvdeyen tvdeyen merged commit 1ab7340 into AlchemyCMS:main Jul 31, 2023
@tvdeyen
Copy link
Member

tvdeyen commented Jul 31, 2023

Ha! github let me edit the squash commit message :) nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants