Convert autocomplete from CoffeeScript to Javascript #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-karnatz
force-pushed
the
update_javascript/move-autocomplete
branch
2 times, most recently
from
792fb77 to
a379f29
Compare
tvdeyen
reviewed
Aug 3, 2023
Move the file also into the app/javascript folder.
sascha-karnatz
force-pushed
the
update_javascript/move-autocomplete
branch
from
a379f29 to
7fc503a
Compare
Renamed the file and the function. |
tvdeyen
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Converted
Alchemy.AutoCompleteinto aautocomplete.js. This is part of the effort to remove all CoffeeScript files and repace them by plain old Javascript.Checklist