Convert Tooltip from Coffeescript to Javascript #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Aug 3, 2023
sascha-karnatz
force-pushed
the
update_javascript/move-tooltip
branch
from
0fc5a29 to
0adce11
Compare
I rewrote the file to use vanilla JS |
sascha-karnatz
force-pushed
the
update_javascript/move-tooltip
branch
3 times, most recently
from
527772d to
49e15d2
Compare
tvdeyen
reviewed
Aug 4, 2023
| * @param {string} text | ||
| * @returns {HTMLElement} | ||
| */ | ||
| export function createHtmlElement(text) { |
There was a problem hiding this comment.
I think createElement is a good enough name.
tvdeyen
requested changes
Aug 4, 2023
Ignore me, I just found that we only use the Very confusing. Maybe worth refactoring into one component? |
sascha-karnatz
force-pushed
the
update_javascript/move-tooltip
branch
2 times, most recently
from
38566b7 to
6420efa
Compare
Move the tooltip also to the app/javascript folder and import the file only in the GUI init - function. It isn't used anywhere else.
Add a dom_helper.js to collect a few repetitive functions.
The tooltip component can only be used on input fields. This way the update of the form builder is way easier. The previous function to transform the jQuery scope to a HTMLElement was removed and the dom helpers - modules is now in the utils folder.
sascha-karnatz
force-pushed
the
update_javascript/move-tooltip
branch
from
6420efa to
0cfaf5b
Compare
tvdeyen
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Move the tooltip also to the app/javascript folder and import the file only in the GUI init - function. It isn't used anywhere else.
Checklist