Convert CharCounter from CoffeeScript to Javascript #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Aug 3, 2023
Also move the file into the app/javascript - folder. Made a small adjustment in the structure of the function.
sascha-karnatz
force-pushed
the
update_javascript/move-char-counter
branch
3 times, most recently
from
1209775 to
1f9b6f6
Compare
tvdeyen
approved these changes
Aug 4, 2023
migrate the data attribute approach to a web component. I does not need a listener and it should be a pretty straight forward way of migrating small peaces of Javascript.
sascha-karnatz
force-pushed
the
update_javascript/move-char-counter
branch
from
1f9b6f6 to
a60123a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Also move the file into the app/javascript - folder. Made a small adjustment in the structure of the function.
Checklist