Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate datepicker into a web component #2554

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Migrate datepicker into a web component #2554

merged 1 commit into from
Aug 25, 2023

Conversation

sascha-karnatz
Copy link
Contributor

What is this pull request for?

migrate datepicker module into a web component. This cleans up the GUI - module even more.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@sascha-karnatz
Migrate datepicker into a web component
6e4af1e 
migrate datepicker module into a web component. This cleans up the GUI - module even more.
@sascha-karnatz sascha-karnatz requested a review from a team August 4, 2023 13:56
@sascha-karnatz sascha-karnatz added this to the 7.1 milestone Aug 4, 2023
tvdeyen
tvdeyen approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 💯

@tvdeyen tvdeyen merged commit 7f0a856 into AlchemyCMS:main Aug 25, 2023
@sascha-karnatz sascha-karnatz deleted the update_javascript/migrate-datepicker-to-web-component branch August 25, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sascha-karnatz @tvdeyen