Replace Spinner with web component #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Aug 30, 2023
sascha-karnatz
force-pushed
the
update_javascript/spinner
branch
5 times, most recently
from
5227498 to
d516b25
Compare
tvdeyen
reviewed
Aug 31, 2023
app/javascript/alchemy_admin/components/alchemy_html_element.js
Outdated
Show resolved
Hide resolved
tvdeyen
requested changes
Aug 31, 2023
sascha-karnatz
force-pushed
the
update_javascript/spinner
branch
from
98d09b6 to
aa901ce
Compare
tvdeyen
reviewed
Aug 31, 2023
try to add a default custom component class for all Alchemy web components. This is inspired from LitElements, but it contains the functions that we are using. The API of the Spinner class is still the same. It is now adding the web component instead of the Handlebars template.
The option is only used in the image gallery, but is now possible to use every color inside the spinner.
sascha-karnatz
force-pushed
the
update_javascript/spinner
branch
from
aa901ce to
9aad4b3
Compare
it is pretty basic for the moment. An update of Jest was necessary to have the latest support for jsdom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Checklist