Web Component Safari fixes #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-karnatz
force-pushed
the
update_javascript/safari-fixes
branch
4 times, most recently
from
055eb6b to
8175f41
Compare
Added a test for AlchemyHTMLElement and test the main functions. Extended this web component base class to proper rerender and use the initial content. Also start with a new component helper to collect offen used utility methods.
sascha-karnatz
force-pushed
the
update_javascript/safari-fixes
branch
from
8175f41 to
9f9de2a
Compare
Instead of extending a HTMLElement create a proper tag that can also be handled by Safari. Add a smaller Jest test to test the basic setup. Update the Alchemy helper to render the datepicker in the new format.
sascha-karnatz
force-pushed
the
update_javascript/safari-fixes
branch
4 times, most recently
from
4553ece to
b1a1f92
Compare
Safari does not support the defined extend syntax and therefor only custom tags can be used. Also a bunch of test for the tinymce are now in place.
It is way easier to use without the relative paths and it allows imports in the class you are going to test.
sascha-karnatz
force-pushed
the
update_javascript/safari-fixes
branch
2 times, most recently
from
bba133c to
cbd402a
Compare
tvdeyen
approved these changes
Sep 15, 2023
| let component = undefined | ||
|
|
||
| beforeEach(() => { | ||
| const html = `<input type="text" is="alchemy-tooltip">` |
There was a problem hiding this comment.
<alchemy-tooltip name="" value="" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Notable changes
<input is="alchemy-datepicker" ...>use<alchemy-datepicker><input .../></alchemy-datepicker><textarea is="alchemy-tinymce" ...></textarea>use<alchemy-tinymce><textarea id="..." ...></textarea></alchemy-tinymce>Checklist