Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Shoelace Tab for tabs #2595

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Use Shoelace Tab for tabs #2595

merged 3 commits into from
Oct 12, 2023

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Oct 11, 2023

What is this pull request for?

Uses the custom element library shoelace for tabs.

Notable changes (remove if none)

Removes another jQueryUI dependency 🎉

Screenshots

Alchemy CMS - All 2023-10-11 12-26-17

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Uses the custom element library shoelace for tabs.
We now use Shoelace tabs
@tvdeyen tvdeyen added this to the 7.1 milestone Oct 12, 2023
@tvdeyen tvdeyen marked this pull request as ready for review October 12, 2023 08:41
@tvdeyen tvdeyen changed the title Use shoelaces tabs for tabs Use Shoelace tabs for tabs Oct 12, 2023
@tvdeyen tvdeyen changed the title Use Shoelace tabs for tabs Use Shoelace Tab for tabs Oct 12, 2023
@tvdeyen tvdeyen merged commit 30b7570 into main Oct 12, 2023
30 checks passed
@tvdeyen tvdeyen deleted the shoelaces branch October 12, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants