Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a NodeSelect web component #2615

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 21, 2023

What is this pull request for?

Convert the jQuery plugin into a web component and use that in the ingredient node editor.

Notable changes (remove if none)

Any calls to alchemyNodeSelect on jQuery objects need to be replaced with this html

<alchemy-node-select placeholder="Search node" url="/api/nodes?include=ancestors">
</alchemy-node-select>

Screenshots

Remove if no visual changes have been made.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 7.1 milestone Nov 21, 2023
@tvdeyen tvdeyen force-pushed the node-select-component branch from dcf5be3 to 4c3d96c Compare November 21, 2023 09:37
@tvdeyen tvdeyen requested a review from a team November 21, 2023 09:37
@tvdeyen tvdeyen force-pushed the node-select-component branch from 4c3d96c to c2234f8 Compare November 21, 2023 09:38
Convert the jQuery plugin into a web component and use that in the ingredient node editor.
@tvdeyen tvdeyen force-pushed the node-select-component branch from c2234f8 to 2a38786 Compare November 21, 2023 12:31
@tvdeyen tvdeyen merged commit 16e843b into AlchemyCMS:main Nov 21, 2023
31 checks passed
@tvdeyen tvdeyen deleted the node-select-component branch November 21, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants