Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload tinymce assets #2620

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 24, 2023

What is this pull request for?

Tinymce loads the editor content css and its plugins on initialize. Since we init tinymce only when its visible it takes long to init the editor. Using browser preload features to make sure the assets are already loaded.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen requested a review from a team November 24, 2023 09:29
Tinymce loads the editor content css and its plugins on initialize.
Since we init tinymce only when its visible it takes long to init the
editor. Using browser preload features to make sure the assets
are already loaded.
@tvdeyen tvdeyen force-pushed the preload-tinymce-assets branch from 05f1ecc to bd50fac Compare November 24, 2023 10:11
@tvdeyen tvdeyen merged commit 2c180a8 into AlchemyCMS:main Nov 24, 2023
31 checks passed
@tvdeyen tvdeyen deleted the preload-tinymce-assets branch November 24, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants