Add alchemy-button web component #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to remove all the Alchemy.Buttons state management code we have right now and let the browser do it for us. This DOES not work in Safari as they do not support extending existing HTML elements, but this is ok in this case. Maybe we will provide a polyfill someday or just do not support this feature in Safari. In order to update forms not using the `alchemy_form_form` helper, replace all usages of `data-alchemy-button` with `is="alchemy-button"`.
tvdeyen
force-pushed
the
alchemy-button-component
branch
from
c682ff0 to
370aa8a
Compare
Jest logs the error that is thrown purposely in this spec.
3 tasks
sascha-karnatz
approved these changes
Nov 28, 2023
| const submit = new Event("submit", { bubbles: true }) | ||
| button.form.dispatchEvent(submit) | ||
|
|
||
| expect(button.getAttribute("disabled")).toEqual("disabled") |
There was a problem hiding this comment.
You could split that into different describe and it - functions. Jest is pretty fast it would desribe, what are you going to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This allows to remove all the
Alchemy.Buttonsstate management code we have right now and let the browser do it for us.This DOES not work in Safari as they do not support extending existing HTML elements, but this is ok in this case. Maybe we will provide a polyfill someday or just do not support this feature in Safari.
In order to update forms not using the
alchemy_form_forhelper, replace all usages ofdata-alchemy-buttonwithis="alchemy-button".Checklist