-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Remix icons #2626
Use Remix icons #2626
Conversation
22ffcd1
to
3eb0817
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very pretty, but the tests are currently a bit broken. We have to update the selectors in the tests as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 28715 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 28740 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 28744 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 28838 lines exceeds the maximum allowed for the inline comments feature.
Fontawesome lacks a lot of icons in the free version. They also do not look modern anymore. Using real open source icons that look modern instead. This also makes a lot of changes to css positioning for icons that before have been made for fontawesome. Now we use much more `display: flex` to make changes like this easier in the future. While doing all that visual work a lot of layout inconsistencies have been removed as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 29174 lines exceeds the maximum allowed for the inline comments feature.
What is this pull request for?
Fontawesome lacks a lot of icons in the free version.
They also do not look modern anymore. Using real open
source icons that look modern instead.
This also makes a lot of changes to css positioning for icons
that before have been made for fontawesome. Now we use much
more
display: flex
to make changes like this easier in the future.While doing all that visual work a lot of inconsitencies have been
removed as well.
Screenshots
Checklist