Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Remix icons #2626

Merged
merged 8 commits into from
Dec 7, 2023
Merged

Use Remix icons #2626

merged 8 commits into from
Dec 7, 2023

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 5, 2023

What is this pull request for?

Fontawesome lacks a lot of icons in the free version.
They also do not look modern anymore. Using real open
source icons that look modern instead.

This also makes a lot of changes to css positioning for icons
that before have been made for fontawesome. Now we use much
more display: flex to make changes like this easier in the future.

While doing all that visual work a lot of inconsitencies have been
removed as well.

Screenshots

Screen Shot 2023-12-06 at 12 57 49
Screen Shot 2023-12-06 at 12 57 45
Screen Shot 2023-12-06 at 12 57 26
Screen Shot 2023-12-06 at 12 57 19
Screen Shot 2023-12-06 at 12 54 02

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen force-pushed the remix-icons branch 10 times, most recently from 22ffcd1 to 3eb0817 Compare December 6, 2023 12:10
@tvdeyen tvdeyen added this to the 7.1 milestone Dec 6, 2023
@tvdeyen tvdeyen marked this pull request as ready for review December 6, 2023 12:14
@tvdeyen tvdeyen requested a review from a team December 6, 2023 12:14
Copy link
Contributor

@sascha-karnatz sascha-karnatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very pretty, but the tests are currently a bit broken. We have to update the selectors in the tests as well.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 28715 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 28740 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 28744 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 28838 lines exceeds the maximum allowed for the inline comments feature.

Fontawesome lacks a lot of icons in the free version.
They also do not look modern anymore. Using real open
source icons that look modern instead.

This also makes a lot of changes to css positioning for icons
that before have been made for fontawesome. Now we use much
more `display: flex` to  make changes like this easier in the future.

While doing all that visual work a lot of layout inconsistencies
have been removed as well.
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 29174 lines exceeds the maximum allowed for the inline comments feature.

@tvdeyen tvdeyen disabled auto-merge December 7, 2023 10:56
@tvdeyen tvdeyen merged commit 7aab57d into main Dec 7, 2023
55 of 56 checks passed
@tvdeyen tvdeyen deleted the remix-icons branch December 7, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants