Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Overlay component #2644

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

sascha-karnatz
Copy link
Contributor

What is this pull request for?

The please wait - overlay was not shown correctly and didn't reacted to Alchemy.pleaseWaitOverlay() - toggle anymore.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

The please wait - overlay was not shown correctly and didn't reacted to Alchemy.pleaseWaitOverlay() - toggle anymore.
@sascha-karnatz sascha-karnatz requested a review from a team December 14, 2023 14:22
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected now! Thanks

width: 100%;
height: 100%;
z-index: 400000;
background-color: rgba(229, 229, 229, 0.4);
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr = #40E5E5E5, endColorstr = #40E5E5E5);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@tvdeyen tvdeyen force-pushed the alchemy-overlay-fix branch from 7d580ea to 0512beb Compare December 14, 2023 14:40
@tvdeyen tvdeyen enabled auto-merge December 14, 2023 14:43
@tvdeyen tvdeyen disabled auto-merge December 14, 2023 14:57
@tvdeyen tvdeyen merged commit ead97f9 into AlchemyCMS:main Dec 14, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants