Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix picture archive layout #2648

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 15, 2023

What is this pull request for?

  1. Transparent images need a background color
  2. SVGs without size attributes need a size on the image
  3. Grid should fill columns by min size

Grid should fill columns by min size so rows with lesser
images than other rows do not center the images but align
them to the start of the grid.
SVGs are having a transparent background and sometimes
they miss a width and height attribute.
Makes it more obvious that this is a background for transparent
picture, like in many photo editor apps.
@tvdeyen tvdeyen force-pushed the fix-picture-archive branch from ed48e91 to a1fa638 Compare December 15, 2023 21:27
@tvdeyen tvdeyen merged commit 6bf5560 into AlchemyCMS:main Dec 15, 2023
31 checks passed
@tvdeyen tvdeyen deleted the fix-picture-archive branch December 15, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants