Fix humanization for add nested element button #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Could please fix the tests as well? |
Converting `nestable_element` to a symbol allows us to humanize the nestable element name.
tvdeyen
force-pushed
the
fix-humanization-for-add-element
branch
from
d0b4292 to
1281ae7
Compare
tvdeyen
approved these changes
Dec 28, 2023
|
@nsaloj fixed the specs for you. Thanks for fixing this long standing issue. |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Add new element button is not humanized for nested elements.
Converting
nestable_elementto a symbol allows us to humanize the nestable element name if a locale translation does not exist, given the i18n helper. See humanize_default_string function.Screenshots
Before:
After:
Checklist