Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for legacy icon styles #2683

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 11, 2024

What is this pull request for?

If a module or extension uses old fontawesome icon styles it now returns the correct style class for remixicons.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 7.1 milestone Jan 11, 2024
@tvdeyen tvdeyen requested a review from a team January 11, 2024 12:30
@tvdeyen tvdeyen enabled auto-merge January 11, 2024 12:30
If a module or extension uses old fontawesome icon styles
it now returns the correct style class for remixicons.
@tvdeyen tvdeyen force-pushed the deprecated-icon-style-support branch from f6996ca to d30b54e Compare January 11, 2024 14:21
@tvdeyen tvdeyen merged commit dc7cc76 into AlchemyCMS:main Jan 11, 2024
34 checks passed
@tvdeyen tvdeyen deleted the deprecated-icon-style-support branch January 11, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants