Use title attribute for link_to_dialog and delete_button tooltip #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a `title` is passed as `html_options` to `link_to_dialog` helper we use that to create a `sl-tooltip`. This way we can progresivly enhance Alchemy extensions and modules to use the new UI Tooltips instead of titles but keep downwards compatibility.
Make it work with buttons nested in a form as well, like the delete button.
If a `title` is passed as `html_options` to `delete_button` helper we use that to create a `sl-tooltip`. This way we can progresivly enhance Alchemy extensions and modules to use the new UI Tooltips instead of titles but keep downwards compatibility.
We changed the selector for form fields inside of forms in dialogs to support tooltips in 69cbb1d
sascha-karnatz
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
If a
titleis passed ashtml_optionstolink_to_dialoganddelete_buttonhelpers we use that to create asl-tooltip.This way we can progressively enhance Alchemy extensions and modules to use the new UI Tooltips instead of titles but keep downwards compatibility.
Checklist