Use Rails' CurrentAttributes to store globals #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
use-current-attributes
branch
from
2579240 to
776fa38
Compare
|
Sweet - would this allow us to remove the |
|
@mamhoff yes, thats why its still WIP |
tvdeyen
force-pushed
the
use-current-attributes
branch
2 times, most recently
from
8a0d153 to
f7cc9a6
Compare
tvdeyen
force-pushed
the
main
branch
3 times, most recently
from
4ea5c7d to
19e4094
Compare
tvdeyen
commented
Feb 28, 2024
tvdeyen
force-pushed
the
use-current-attributes
branch
2 times, most recently
from
a696479 to
322bea8
Compare
This deprecates - `Alchemy::Site.current` - `Alchemy::Language.current` in favor of `Alchemy::Current.site` `Alchemy::Current.language` Also introduces - `Alchemy::Current.preview_page`
This is an alias for `Site.first`. Use that instead.
We use Alchemy::Current now, that uses Rails' built in CurrentAttributes instead.
tvdeyen
force-pushed
the
use-current-attributes
branch
from
322bea8 to
654e9e9
Compare
tvdeyen
changed the title
tvdeyen
force-pushed
the
use-current-attributes
branch
from
654e9e9 to
2cf2ff0
Compare
|
@mamhoff ready for review |
mamhoff
reviewed
Mar 5, 2024
tvdeyen
added a commit
to tvdeyen/alchemy_cms
that referenced
this pull request
Sep 3, 2024
With Alchemy 7.2 (AlchemyCMS#2701) we started to use `Alchemy::Current.page` for rendering elements of current page. If one has a custom controller to render Alchemy content with: render(template: "alchemy/pages/show") it is now empty if `Alchemy::Current.page` is not set. Someday we might deprecate the `@page` instance variable, but until then we need to fall back to it.
3 tasks
tvdeyen
added a commit
to tvdeyen/alchemy_cms
that referenced
this pull request
Sep 3, 2024
Since Alchemy 7.2 (AlchemyCMS#2701) we need to set `Alchemy::Page.current` if we want to render a page from another controller.
3 tasks
tvdeyen
added a commit
that referenced
this pull request
Sep 4, 2024
With Alchemy 7.2 (#2701) we started to use `Alchemy::Current.page` for rendering elements of current page. If one has a custom controller to render Alchemy content with: render(template: "alchemy/pages/show") it is now empty if `Alchemy::Current.page` is not set. Someday we might deprecate the `@page` instance variable, but until then we need to fall back to it. (cherry picked from commit 26072ab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Instead of our own custom implementation for Alchemy globals that
use the
request_storegem, we use Rails' built in Current Attributes.Notable changes
Alchemy::Page.current_preview,Alchemy::Language.currentandAlchemy::Site.currentare now deprecatedand replaced by
Alchemy::Current.preview_page,Alchemy::Current.languageandAlchemy::Current.site.We also introduced a new global
Alchemy::Current.preview_page?that returnstrueif the current rendered pageis also the page currently previewed in page editor. You should use that instead of
@preview_mode.Checklist